Messages in this thread | | | Subject | Re: [PATCH][next] selinux: fix allocation failure check on newpolicy->sidtab | From | Stephen Smalley <> | Date | Wed, 19 Aug 2020 08:21:54 -0400 |
| |
On 8/19/20 6:42 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com> > > The allocation check of newpolicy->sidtab is null checking if > newpolicy is null and not newpolicy->sidtab. Fix this. > > Addresses-Coverity: ("Logically dead code") > Fixes: c7c556f1e81b ("selinux: refactor changing booleans") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com> > --- > security/selinux/ss/services.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c > index f6f78c65f53f..d310910fb639 100644 > --- a/security/selinux/ss/services.c > +++ b/security/selinux/ss/services.c > @@ -2224,7 +2224,7 @@ int security_load_policy(struct selinux_state *state, void *data, size_t len, > return -ENOMEM; > > newpolicy->sidtab = kzalloc(sizeof(*newpolicy->sidtab), GFP_KERNEL); > - if (!newpolicy) > + if (!newpolicy->sidtab) > goto err; > > rc = policydb_read(&newpolicy->policydb, fp);
| |