lkml.org 
[lkml]   [2020]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 18/28] wireless: rsi: rsi_91x_mac80211: Fix a few kerneldoc misdemeanours
    Date
     - File headers should not be kernel-doc
    - Misnaming issues
    - Missing function parameter documentation

    Fixes the following W=1 kernel build warning(s):

    drivers/net/wireless/rsi/rsi_91x_mac80211.c:24: warning: cannot understand function prototype: 'const struct ieee80211_channel rsi_2ghz_channels[] = '
    drivers/net/wireless/rsi/rsi_91x_mac80211.c:739: warning: Function parameter or member 'vif' not described in 'rsi_get_connected_channel'
    drivers/net/wireless/rsi/rsi_91x_mac80211.c:739: warning: Excess function parameter 'adapter' description in 'rsi_get_connected_channel'
    drivers/net/wireless/rsi/rsi_91x_mac80211.c:868: warning: Function parameter or member 'changed_flags' not described in 'rsi_mac80211_conf_filter'
    drivers/net/wireless/rsi/rsi_91x_mac80211.c:868: warning: Excess function parameter 'changed' description in 'rsi_mac80211_conf_filter'
    drivers/net/wireless/rsi/rsi_91x_mac80211.c:946: warning: Function parameter or member 'sta' not described in 'rsi_hal_key_config'
    drivers/net/wireless/rsi/rsi_91x_mac80211.c:1245: warning: Function parameter or member 'vif' not described in 'rsi_perform_cqm'

    Cc: Amitkumar Karwar <amitkarwar@gmail.com>
    Cc: Siva Rebbagondla <siva8118@gmail.com>
    Cc: Kalle Valo <kvalo@codeaurora.org>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: Jakub Kicinski <kuba@kernel.org>
    Cc: linux-wireless@vger.kernel.org
    Cc: netdev@vger.kernel.org
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/net/wireless/rsi/rsi_91x_mac80211.c | 9 +++++----
    1 file changed, 5 insertions(+), 4 deletions(-)

    diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
    index 5c0adb0efc5d6..ce223e680cba6 100644
    --- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
    +++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
    @@ -1,4 +1,4 @@
    -/**
    +/*
    * Copyright (c) 2014 Redpine Signals Inc.
    *
    * Permission to use, copy, modify, and/or distribute this software for any
    @@ -731,7 +731,7 @@ static int rsi_mac80211_config(struct ieee80211_hw *hw,
    /**
    * rsi_get_connected_channel() - This function is used to get the current
    * connected channel number.
    - * @adapter: Pointer to the adapter structure.
    + * @vif: Pointer to the ieee80211_vif structure.
    *
    * Return: Current connected AP's channel number is returned.
    */
    @@ -855,7 +855,7 @@ static void rsi_mac80211_bss_info_changed(struct ieee80211_hw *hw,
    /**
    * rsi_mac80211_conf_filter() - This function configure the device's RX filter.
    * @hw: Pointer to the ieee80211_hw structure.
    - * @changed: Changed flags set.
    + * @changed_flags: Changed flags set.
    * @total_flags: Total initial flags set.
    * @multicast: Multicast.
    *
    @@ -936,6 +936,7 @@ static int rsi_mac80211_conf_tx(struct ieee80211_hw *hw,
    * @hw: Pointer to the ieee80211_hw structure.
    * @vif: Pointer to the ieee80211_vif structure.
    * @key: Pointer to the ieee80211_key_conf structure.
    + * @sta: Pointer to the ieee80211_sta structure.
    *
    * Return: status: 0 on success, negative error codes on failure.
    */
    @@ -1008,7 +1009,6 @@ static int rsi_hal_key_config(struct ieee80211_hw *hw,
    * @hw: Pointer to the ieee80211_hw structure.
    * @cmd: enum set_key_cmd.
    * @vif: Pointer to the ieee80211_vif structure.
    - * @sta: Pointer to the ieee80211_sta structure.
    * @key: Pointer to the ieee80211_key_conf structure.
    *
    * Return: status: 0 on success, negative error code on failure.
    @@ -1237,6 +1237,7 @@ static int rsi_mac80211_set_rate_mask(struct ieee80211_hw *hw,
    * @common: Pointer to the driver private structure.
    * @bssid: pointer to the bssid.
    * @rssi: RSSI value.
    + * @vif: Pointer to the ieee80211_vif structure.
    */
    static void rsi_perform_cqm(struct rsi_common *common,
    u8 *bssid,
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-08-19 09:27    [W:3.361 / U:0.548 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site