lkml.org 
[lkml]   [2020]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 15/18] tools/testing/selftests/cgroup/cgroup_util.c: cg_read_strcmp: fix null pointer dereference
    Date
    From: Gaurav Singh <gaurav1086@gmail.com>

    [ Upstream commit d830020656c5b68ced962ed3cb51a90e0a89d4c4 ]

    Haven't reproduced this issue. This PR is does a minor code cleanup.

    Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
    Cc: Shuah Khan <shuah@kernel.org>
    Cc: Tejun Heo <tj@kernel.org>
    Cc: Michal Koutn <mkoutny@suse.com>
    Cc: Roman Gushchin <guro@fb.com>
    Cc: Christian Brauner <christian.brauner@ubuntu.com>
    Cc: Chris Down <chris@chrisdown.name>
    Link: http://lkml.kernel.org/r/20200726013808.22242-1-gaurav1086@gmail.com
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/cgroup/cgroup_util.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c
    index 075cb0c730149..90418d79ef676 100644
    --- a/tools/testing/selftests/cgroup/cgroup_util.c
    +++ b/tools/testing/selftests/cgroup/cgroup_util.c
    @@ -95,7 +95,7 @@ int cg_read_strcmp(const char *cgroup, const char *control,

    /* Handle the case of comparing against empty string */
    if (!expected)
    - size = 32;
    + return -1;
    else
    size = strlen(expected) + 1;

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-08-20 02:08    [W:4.530 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site