lkml.org 
[lkml]   [2020]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/2] nvme: add emulation for zone-append
    From
    Date
    On Tue, 2020-08-18 at 07:12 +0000, Christoph Hellwig wrote:
    > On Tue, Aug 18, 2020 at 10:59:36AM +0530, Kanchan Joshi wrote:
    > > If drive does not support zone-append natively, enable emulation
    > > using
    > > regular write.
    > > Make emulated zone-append cmd write-lock the zone, preventing
    > > concurrent append/write on the same zone.
    >
    > I really don't think we should add this. ZNS and the Linux support
    > were all designed with Zone Append in mind, and then your company did
    > the nastiest possible move violating the normal NVMe procedures to
    > make
    > it optional. But that doesn't change the fact the Linux should keep
    > requiring it, especially with the amount of code added here and how
    > it
    > hooks in the fast path.

    Intel does not support making *optional* NVMe spec features *required*
    by the NVMe driver.

    It's forgivable WDC's accepted contribution didn't work with other
    vendors' devices choosing not to implement the optional Zone Append,
    but it's not OK to reject contributions remedying this. Provided
    there's no glaring technical issues, Samsung's contribution should be
    accepted to maintain both spec compliance as well as vendor neutrality.


    \
     
     \ /
      Last update: 2020-08-19 21:12    [W:2.556 / U:0.784 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site