lkml.org 
[lkml]   [2020]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] Fixes: tty: serial: earlycon dependency
Thanks Greg and Jiri for your suggestion!
I made another attempt to fix those problems. Hope it will work this time.
Thank you!

On Tue, Aug 18, 2020 at 7:19 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Mon, Aug 17, 2020 at 02:54:19PM -0400, Tong Zhang wrote:
> > parse_options() in drivers/tty/serial/earlycon.c calls uart_parse_earlycon
> > in drivers/tty/serial/serial_core.c therefore selecting SERIAL_EARLYCON
> > should automatically select SERIAL_CORE, otherwise will result in symbol
> > not found error during linking if SERIAL_CORE is not configured as builtin
> >
> > Signed-off-by: Tong Zhang <ztong0001@gmail.com>
>
> As Jiri pointed out, the Fixes: line goes down here, not in your subject
> line :)
>
> Please fix up, thanks.
>
> > ---
> > drivers/tty/serial/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
>
> What changed from v1? Also always list that below the --- line so we
> know.
>
> thanks,
>
> greg k-h

\
 
 \ /
  Last update: 2020-08-18 18:29    [W:0.073 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site