lkml.org 
[lkml]   [2020]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v7 6/6] libceph: use sendpage_ok() in ceph_tcp_sendpage()
    Date
    In libceph, ceph_tcp_sendpage() does the following checks before handle
    the page by network layer's zero copy sendpage method,
    if (page_count(page) >= 1 && !PageSlab(page))

    This check is exactly what sendpage_ok() does. This patch replace the
    open coded checks by sendpage_ok() as a code cleanup.

    Signed-off-by: Coly Li <colyli@suse.de>
    Cc: Ilya Dryomov <idryomov@gmail.com>
    Cc: Jeff Layton <jlayton@kernel.org>
    ---
    net/ceph/messenger.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
    index 27d6ab11f9ee..6a349da7f013 100644
    --- a/net/ceph/messenger.c
    +++ b/net/ceph/messenger.c
    @@ -575,7 +575,7 @@ static int ceph_tcp_sendpage(struct socket *sock, struct page *page,
    * coalescing neighboring slab objects into a single frag which
    * triggers one of hardened usercopy checks.
    */
    - if (page_count(page) >= 1 && !PageSlab(page))
    + if (sendpage_ok(page))
    sendpage = sock->ops->sendpage;
    else
    sendpage = sock_no_sendpage;
    --
    2.26.2
    \
     
     \ /
      Last update: 2020-08-18 15:15    [W:2.504 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site