lkml.org 
[lkml]   [2020]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] net: Avoid strcmp current->comm with warncomm when warned >= 5
Date
David Miller <davem@davemloft.net> wrote:
>From: Miaohe Lin <linmiaohe@huawei.com>
>Date: Tue, 18 Aug 2020 07:41:32 -0400
>
>> @@ -417,7 +417,7 @@ static void sock_warn_obsolete_bsdism(const char
>> *name) {
>> static int warned;
>> static char warncomm[TASK_COMM_LEN];
>> - if (strcmp(warncomm, current->comm) && warned < 5) {
>> + if (warned < 5 && strcmp(warncomm, current->comm)) {
>> strcpy(warncomm, current->comm);
>> pr_warn("process `%s' is using obsolete %s SO_BSDCOMPAT\n",
>> warncomm, name);
>
>We've been warning about SO_BSDCOMPAT usage for almost 20 years, I think we can remove this code completely now.

Looks sane. Will do. Many thanks.

\
 
 \ /
  Last update: 2020-08-19 03:50    [W:0.028 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site