Messages in this thread | | | Date | Tue, 18 Aug 2020 12:45:17 -0700 (PDT) | Subject | Re: [PATCH] net: Avoid strcmp current->comm with warncomm when warned >= 5 | From | David Miller <> |
| |
From: Miaohe Lin <linmiaohe@huawei.com> Date: Tue, 18 Aug 2020 07:41:32 -0400
> @@ -417,7 +417,7 @@ static void sock_warn_obsolete_bsdism(const char *name) > { > static int warned; > static char warncomm[TASK_COMM_LEN]; > - if (strcmp(warncomm, current->comm) && warned < 5) { > + if (warned < 5 && strcmp(warncomm, current->comm)) { > strcpy(warncomm, current->comm); > pr_warn("process `%s' is using obsolete %s SO_BSDCOMPAT\n", > warncomm, name);
We've been warning about SO_BSDCOMPAT usage for almost 20 years, I think we can remove this code completely now.
| |