Messages in this thread | | | From | Rob Herring <> | Date | Mon, 17 Aug 2020 08:13:47 -0600 | Subject | Re: [PATCH 43/44] dt: document HiSilicon SPMI controller and mfd/regulator properties |
| |
On Sat, Aug 15, 2020 at 3:55 AM Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote: > > Hi Rob, > > Em Fri, 14 Aug 2020 14:17:08 -0600 > Rob Herring <robh@kernel.org> escreveu: > > > On Wed, 12 Aug 2020 17:56:53 +0200, Mauro Carvalho Chehab wrote: > > > Add documentation for the properties needed by the HiSilicon > > > 6421v600 driver, and by the SPMI controller used to access > > > the chipset. > > > > > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > > > --- > > > .../mfd/hisilicon,hi6421-spmi-pmic.yaml | 182 ++++++++++++++++++ > > > .../spmi/hisilicon,hisi-spmi-controller.yaml | 54 ++++++ > > > 2 files changed, 236 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml > > > create mode 100644 Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.yaml > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.example.dt.yaml: example-0: spmi@fff24000:reg:0: [0, 4294066176, 0, 4096] is too long > > I was unable to find any way to solve this one. What's the proper > way to set the length of the root reg on some example?
The default is 1 address and size cell. Either adjust 'reg' for that or you can define a bus node:
bus { #address-cells = <2>; #size-cells = <2>;
spmi@123 { ... }; };
My preference is doing the former.
Rob
| |