lkml.org 
[lkml]   [2020]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 186/464] cxl: Fix kobject memleak
    Date
    From: Wang Hai <wanghai38@huawei.com>

    [ Upstream commit 85c5cbeba8f4fb28e6b9bfb3e467718385f78f76 ]

    Currently the error return path from kobject_init_and_add() is not
    followed by a call to kobject_put() - which means we are leaking
    the kobject.

    Fix it by adding a call to kobject_put() in the error path of
    kobject_init_and_add().

    Fixes: b087e6190ddc ("cxl: Export optional AFU configuration record in sysfs")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Wang Hai <wanghai38@huawei.com>
    Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
    Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
    Link: https://lore.kernel.org/r/20200602120733.5943-1-wanghai38@huawei.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/misc/cxl/sysfs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/misc/cxl/sysfs.c b/drivers/misc/cxl/sysfs.c
    index f0263d1a1fdf2..d97a243ad30c0 100644
    --- a/drivers/misc/cxl/sysfs.c
    +++ b/drivers/misc/cxl/sysfs.c
    @@ -624,7 +624,7 @@ static struct afu_config_record *cxl_sysfs_afu_new_cr(struct cxl_afu *afu, int c
    rc = kobject_init_and_add(&cr->kobj, &afu_config_record_type,
    &afu->dev.kobj, "cr%i", cr->cr);
    if (rc)
    - goto err;
    + goto err1;

    rc = sysfs_create_bin_file(&cr->kobj, &cr->config_attr);
    if (rc)
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-08-17 21:35    [W:3.937 / U:0.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site