lkml.org 
[lkml]   [2020]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 289/393] qtnfmac: Missing platform_device_unregister() on error in qtnf_core_mac_alloc()
    Date
    From: Wang Hai <wanghai38@huawei.com>

    [ Upstream commit 141bc9abbbffa89d020957caa9ac4a61d0ef1e26 ]

    Add the missing platform_device_unregister() before return from
    qtnf_core_mac_alloc() in the error handling case.

    Fixes: 616f5701f4ab ("qtnfmac: assign each wiphy to its own virtual platform device")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Wang Hai <wanghai38@huawei.com>
    Reviewed-by: Sergey Matyukevich <geomatsi@gmail.com>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Link: https://lore.kernel.org/r/20200730064910.37589-1-wanghai38@huawei.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/quantenna/qtnfmac/core.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/quantenna/qtnfmac/core.c b/drivers/net/wireless/quantenna/qtnfmac/core.c
    index eea777f8acea5..6aafff9d4231b 100644
    --- a/drivers/net/wireless/quantenna/qtnfmac/core.c
    +++ b/drivers/net/wireless/quantenna/qtnfmac/core.c
    @@ -446,8 +446,11 @@ static struct qtnf_wmac *qtnf_core_mac_alloc(struct qtnf_bus *bus,
    }

    wiphy = qtnf_wiphy_allocate(bus, pdev);
    - if (!wiphy)
    + if (!wiphy) {
    + if (pdev)
    + platform_device_unregister(pdev);
    return ERR_PTR(-ENOMEM);
    + }

    mac = wiphy_priv(wiphy);

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-08-17 20:48    [W:5.389 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site