lkml.org 
[lkml]   [2020]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFT v2 21/29] memory: omap-gpmc: Remove GPMC_SET_ONE_CD_MAX macro for safety
On Fri, Jul 24, 2020 at 09:40:30AM +0200, Krzysztof Kozlowski wrote:
> The GPMC_SET_ONE_CD_MAX macro uses return statement and variable 'cs'
> coming from called scope. This is not a good practice. Also
> checkpatch complained:
>
> WARNING: Macros with flow control statements should be avoided
> ERROR: Macros starting with if should be enclosed by a do - while
> loop to avoid possible if/else logic defects
>
> Since GPMC_SET_ONE_CD_MAX macro just calls one function, it can be open
> coded. The difference with original code is that function will exit on
> error not after every register set, but after a group of sets.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>

Applied.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2020-08-17 20:34    [W:0.182 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site