lkml.org 
[lkml]   [2020]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/30] net: wireless: broadcom: b43: main: Add braces around empty statements
    On Fri, 14 Aug 2020, Kalle Valo wrote:

    > Lee Jones <lee.jones@linaro.org> writes:
    >
    > > Fixes the following W=1 kernel build warning(s):
    > >
    > > drivers/net/wireless/broadcom/b43/main.c: In function ‘b43_dummy_transmission’:
    > > drivers/net/wireless/broadcom/b43/main.c:785:3: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
    > > drivers/net/wireless/broadcom/b43/main.c: In function ‘b43_do_interrupt_thread’:
    > > drivers/net/wireless/broadcom/b43/main.c:2017:3: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
    > >
    > > Cc: Kalle Valo <kvalo@codeaurora.org>
    > > Cc: "David S. Miller" <davem@davemloft.net>
    > > Cc: Jakub Kicinski <kuba@kernel.org>
    > > Cc: Martin Langer <martin-langer@gmx.de>
    > > Cc: Stefano Brivio <stefano.brivio@polimi.it>
    > > Cc: Michael Buesch <m@bues.ch>
    > > Cc: van Dyk <kugelfang@gentoo.org>
    > > Cc: Andreas Jaggi <andreas.jaggi@waterwave.ch>
    > > Cc: Albert Herranz <albert_herranz@yahoo.es>
    > > Cc: linux-wireless@vger.kernel.org
    > > Cc: b43-dev@lists.infradead.org
    > > Cc: netdev@vger.kernel.org
    > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
    > > ---
    > > drivers/net/wireless/broadcom/b43/main.c | 6 ++++--
    > > 1 file changed, 4 insertions(+), 2 deletions(-)
    >
    > Please don't copy the full directory structure to the title. I'll change
    > the title to more simple version:
    >
    > b43: add braces around empty statements

    This seems to go the other way.

    "net: wireless: b43" seems sensible.

    > I'll do similar changes to other wireless-drivers patches.

    Thanks.

    Does that mean it's been applied, or is this future tense?

    --
    Lee Jones [李琼斯]
    Senior Technical Lead - Developer Services
    Linaro.org │ Open source software for Arm SoCs
    Follow Linaro: Facebook | Twitter | Blog

    \
     
     \ /
      Last update: 2020-08-14 18:45    [W:2.337 / U:1.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site