Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues | Date | Fri, 14 Aug 2020 18:15:39 +0300 |
| |
Lee Jones <lee.jones@linaro.org> writes:
> - Ensure spaces appear after {for, if, while, etc} > - Ensure spaces to not appear after '(' > - Ensure spaces to not appear before ')' > - Ensure spaces appear between ')' and '{' > - Ensure spaces appear after ',' > - Ensure spaces do not appear before ',' > - Ensure spaces appear either side of '=' > - Ensure '{'s which open functions are on a new line > - Remove trailing whitespace > > There are still a whole host of issues with this file, but this > patch certainly breaks the back of them. > > Cc: Kalle Valo <kvalo@codeaurora.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Benjamin Reed <breed@users.sourceforge.net> > Cc: Javier Achirica <achirica@users.sourceforge.net> > Cc: Jean Tourrilhes <jt@hpl.hp.com> > Cc: Fabrice Bellet <fabrice@bellet.info> > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/net/wireless/cisco/airo.c | 897 ++++++++++++++++-------------- > 1 file changed, 467 insertions(+), 430 deletions(-)
This is a driver for ancient hardware, I'm not sure if it's worth trying to fix any style issues. Is anyone even using it? Should we instead just remove the driver?
-- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |