lkml.org 
[lkml]   [2020]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] drivers: hv: dxgkrnl: core code
On Fri, Aug 14, 2020 at 08:38:53AM -0400, Sasha Levin wrote:
> Add support for a Hyper-V based vGPU implementation that exposes the
> DirectX API to Linux userspace.

Api questions:

> +struct d3dkmthandle {
> + union {
> + struct {
> + u32 instance : 6;
> + u32 index : 24;
> + u32 unique : 2;

What is the endian of this?

> + };
> + u32 v;
> + };
> +};
> +
> +extern const struct d3dkmthandle zerohandle;
> +
> +struct ntstatus {
> + union {
> + struct {
> + int code : 16;
> + int facility : 13;
> + int customer : 1;
> + int severity : 2;

Same here.

Are these things that cross the user/kernel boundry?

And why int on one and u32 on the other?

> + };
> + int v;
> + };
> +};
> +
> +struct winluid {
> + uint a;
> + uint b;

And now uint? Come on, be consistent please :)

thanks,

greg k-h

\
 
 \ /
  Last update: 2020-08-14 14:59    [W:1.936 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site