lkml.org 
[lkml]   [2020]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] nvme-pci: cancel nvme device request before disabling
    On Fri, Aug 14, 2020 at 03:14:31AM -0400, Tong Zhang wrote:
    > This patch addresses an irq free warning and null pointer dereference
    > error problem when nvme devices got timeout error during initialization.
    > This problem happens when nvme_timeout() function is called while
    > nvme_reset_work() is still in execution. This patch fixed the problem by
    > setting flag of the problematic request to NVME_REQ_CANCELLED before
    > calling nvme_dev_disable() to make sure __nvme_submit_sync_cmd() returns
    > an error code and let nvme_submit_sync_cmd() fail gracefully.
    > The following is console output.

    The commit log looks a little weird due to the extra indentation.

    The patch itself looks good, though:

    Reviewed-by: Christoph Hellwig <hch@lst.de>

    \
     
     \ /
      Last update: 2020-08-14 10:17    [W:4.449 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site