Messages in this thread | | | Subject | Re: [PATCH] x86/pci: fix intel_mid_pci.c build error when ACPI is not enabled | From | Arjan van de Ven <> | Date | Thu, 13 Aug 2020 13:23:59 -0700 |
| |
On 8/13/2020 12:58 PM, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > Fix build error when CONFIG_ACPI is not set/enabled by adding > the header file <asm/acpi.h> which contains a stub for the function > in the build error. > > ../arch/x86/pci/intel_mid_pci.c: In function ‘intel_mid_pci_init’: > ../arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration] > acpi_noirq_set(); > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Jacob Pan <jacob.jun.pan@linux.intel.com> > Cc: Len Brown <lenb@kernel.org> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Jesse Barnes <jsbarnes@google.com> > Cc: Arjan van de Ven <arjan@linux.intel.com> > Cc: linux-pci@vger.kernel.org > --- > Found in linux-next, but applies to/exists in mainline also. > > Alternative.1: X86_INTEL_MID depends on ACPI > Alternative.2: drop X86_INTEL_MID support
at this point I'd suggest Alternative 2; the products that needed that (past tense, that technology is no longer need for any newer products) never shipped in any form where a 4.x or 5.x kernel could work, and they are also all locked down...
| |