Messages in this thread | | | Date | Thu, 13 Aug 2020 09:54:10 +0800 | From | Leo Yan <> | Subject | Re: [PATCH v2 0/4] Perf tool: Enable Arm arch timer counter and arm-spe's timestamp |
| |
On Wed, Aug 12, 2020 at 03:53:34PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Aug 12, 2020 at 10:06:53AM -0600, Mathieu Poirier escreveu: > > Hi Arnaldo, > > > > On Fri, 7 Aug 2020 at 01:16, Leo Yan <leo.yan@linaro.org> wrote: > > > > > > This patch set is to enable Arm arch timer counter and Arm SPE is the > > > first customer to use arch timer counter for its timestamp. > > > > > > Patches 01 ~ 03 enables Arm arch timer counter in Perf tool; patch 01 is > > > to retrieve arch timer's parameters from mmaped page; patch 02 provides > > > APIs for the conversion between arch timer's counter and time; patch 03 > > > adds a test for patches 01 and 02. > > > > > > As the first customer to use Arm arch timer counter in perf tool, patch > > > 04 is to generate sample's timestamp for ARM SPE AUX trace data. > > > > > > This patch set has been rebased on perf/core branch with the latest > > > commit c4735d990268 ("perf evsel: Don't set > > > sample_regs_intr/sample_regs_user for dummy event"). > > > > The ARM SPE perf tools code is orphan and I don't have the cycles to > > pick it up. Leo has spent a lot of time in that code and as such I > > suggest that he starts maintaining it, probably following the same > > kind of arrangement you and I have for coresight. > > Thats ok with me, I think we should reflect that on the MAINTAINERS > file, right?
Very appreciate for the promoting, Mathieu and Arnaldo.
> We have this already: > > PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS > R: John Garry <john.garry@huawei.com> > R: Will Deacon <will@kernel.org> > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > S: Supported > F: tools/perf/pmu-events/arch/arm64/ > > I think we should have entries for CoreSight and ARM SPE, one listing > you as the maintainer and the other listing Leo, right? > > Leo, it would be good for you to try and find someone at your > organization or elsewhere that could help with this, this way I would > wait a bit, see if someone else Acks it, and collect those, processing > it from you after a while if nobody chimes in.
I will follow up this and might offline to check with relevant maintainers (Will and John) for what's good way to proceed.
> Please continue providing 'perf test' regression tests, etc, to help > with maintaining this code being checked.
Sure, I'm glad to continue the maintaining and testing works :)
Thanks, Leo
| |