Messages in this thread | | | Subject | Re: [PATCH] [v2] tools/objtool: Fix unnecessary jumps | From | Kamalesh Babulal <> | Date | Tue, 11 Aug 2020 20:54:10 +0530 |
| |
On 11/08/20 9:48 am, Youling Tang wrote: > There is no need to jump to the "out" tag when "ret < 0", just return > directly to "ret". > > Signed-off-by: Youling Tang <tangyouling@loongson.cn>
the patch looks good to me, the commit message doesn't explain the reason for the change. It can be written like:
"Previously cleanup() function was called under the out label for both fatal errors (ret < 0) and warnings. Now that cleanup() function is removed, the out label is no longer required. Remove it and return immediately for the fatal errors with ret as return code and 0 for warnings."
Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
-- Kamalesh
| |