Messages in this thread | | | Subject | Re: [PATCH v2] loop: unset GENHD_FL_NO_PART_SCAN on LOOP_CONFIGURE | From | Jens Axboe <> | Date | Tue, 11 Aug 2020 07:13:33 -0600 |
| |
On 8/11/20 12:49 AM, Martijn Coenen wrote: > On Mon, Aug 10, 2020 at 7:16 PM Lennart Poettering <mzxreary@0pointer.de> wrote: >> >> When LOOP_CONFIGURE is used with LO_FLAGS_PARTSCAN we need to propagate >> this into the GENHD_FL_NO_PART_SCAN. LOOP_SETSTATUS does this, >> LOOP_CONFIGURE doesn't so far. Effect is that setting up a loopback >> device with partition scanning doesn't actually work when LOOP_CONFIGURE >> is issued, though it works fine with LOOP_SETSTATUS. >> >> Let's correct that and propagate the flag in LOOP_CONFIGURE too. >> >> Fixes: 3448914e8cc5("loop: Add LOOP_CONFIGURE ioctl") >> >> Signed-off-by: Lennart Poettering <lennart@poettering.net> >> Acked-by: Martijn Coenen <maco@android.com> > > Thanks, still looks good to me.
Applied.
-- Jens Axboe
| |