Messages in this thread | | | Subject | Re: [PATCH v2 2/3] perf/x86/rapl: Support multiple rapl unit quirks | From | Zhang Rui <> | Date | Wed, 12 Aug 2020 11:29:06 +0800 |
| |
Hi,
Thanks for reviewing.
On Tue, 2020-08-11 at 11:19 -0700, Joe Perches wrote: > On Tue, 2020-08-11 at 23:31 +0800, Zhang Rui wrote: > > There will be more platforms with different fixed energy units. > > Enhance the code to support different rapl unit quirks for > > different > > platforms. > > This seems like one quirk per platform. > > Should multiple quirks on individual platforms be supported? > enum rapl_unit_quirk is just used as a flag. multiple quirks can be deployed with the same flag, just like what I did in patch 3/3. Also different platforms can either have different flags or share the same flag.
thanks, rui
> > diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c > > [] > > @@ -130,11 +130,16 @@ struct rapl_pmus { > > struct rapl_pmu *pmus[]; > > }; > > > > +enum rapl_unit_quirk { > > + RAPL_UNIT_QUIRK_NONE, > > + RAPL_UNIT_QUIRK_INTEL_HSW, > > +}; > > + > > struct rapl_model { > > struct perf_msr *rapl_msrs; > > unsigned long events; > > unsigned int msr_power_unit; > > - bool apply_quirk; > > + enum rapl_unit_quirk unit_quirk; > > }; > >
| |