lkml.org 
[lkml]   [2020]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 37/79] nvme-pci: prevent SK hynix PC400 from using Write Zeroes command
    Date
    From: Kai-Heng Feng <kai.heng.feng@canonical.com>

    [ Upstream commit 5611ec2b9814bc91f7b0a8d804c1fc152e2025d9 ]

    After commit 6e02318eaea5 ("nvme: add support for the Write Zeroes
    command"), SK hynix PC400 becomes very slow with the following error
    message:

    [ 224.567695] blk_update_request: operation not supported error, dev nvme1n1, sector 499384320 op 0x9:(WRITE_ZEROES) flags 0x1000000 phys_seg 0 prio class 0]

    SK Hynix PC400 has a buggy firmware that treats NLB as max value instead
    of a range, so the NLB passed isn't a valid value to the firmware.

    According to SK hynix there are three commands are affected:
    - Write Zeroes
    - Compare
    - Write Uncorrectable

    Right now only Write Zeroes is implemented, so disable it completely on
    SK hynix PC400.

    BugLink: https://bugs.launchpad.net/bugs/1872383
    Cc: kyounghwan sohn <kyounghwan.sohn@sk.com>
    Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/nvme/host/pci.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
    index 10d65f27879fd..45e29c6c3234c 100644
    --- a/drivers/nvme/host/pci.c
    +++ b/drivers/nvme/host/pci.c
    @@ -3130,6 +3130,8 @@ static const struct pci_device_id nvme_id_table[] = {
    { PCI_DEVICE(0x1cc1, 0x8201), /* ADATA SX8200PNP 512GB */
    .driver_data = NVME_QUIRK_NO_DEEPEST_PS |
    NVME_QUIRK_IGNORE_DEV_SUBNQN, },
    + { PCI_DEVICE(0x1c5c, 0x1504), /* SK Hynix PC400 */
    + .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
    { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
    { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001),
    .driver_data = NVME_QUIRK_SINGLE_VECTOR },
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-08-10 17:40    [W:4.620 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site