lkml.org 
[lkml]   [2020]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 06/38] Revert "ALSA: hda: call runtime_allow() for all hda controllers"
    Date
    From: Hui Wang <hui.wang@canonical.com>

    commit 07c9983b567d0ef33aefc063299de95a987e12a8 upstream.

    This reverts commit 9a6418487b56 ("ALSA: hda: call runtime_allow()
    for all hda controllers").

    The reverted patch already introduced some regressions on some
    machines:
    - on gemini-lake machines, the error of "azx_get_response timeout"
    happens in the hda driver.
    - on the machines with alc662 codec, the audio jack detection doesn't
    work anymore.

    Fixes: 9a6418487b56 ("ALSA: hda: call runtime_allow() for all hda controllers")
    BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=208511
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Hui Wang <hui.wang@canonical.com>
    Link: https://lore.kernel.org/r/20200803064638.6139-1-hui.wang@canonical.com
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/pci/hda/hda_intel.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/sound/pci/hda/hda_intel.c
    +++ b/sound/pci/hda/hda_intel.c
    @@ -2354,7 +2354,6 @@ static int azx_probe_continue(struct azx

    if (azx_has_pm_runtime(chip)) {
    pm_runtime_use_autosuspend(&pci->dev);
    - pm_runtime_allow(&pci->dev);
    pm_runtime_put_autosuspend(&pci->dev);
    }


    \
     
     \ /
      Last update: 2020-08-10 17:20    [W:2.480 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site