Messages in this thread Patch in this message | | | From | Miaohe Lin <> | Subject | [PATCH] net: eliminate meaningless memcpy to data in pskb_carve_inside_nonlinear() | Date | Mon, 10 Aug 2020 08:28:56 -0400 |
| |
The skb_shared_info part of the data is assigned in the following loop. It is meaningless to do a memcpy here.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- net/core/skbuff.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 7e2e502ef519..5b983c9472f5 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -5952,9 +5952,6 @@ static int pskb_carve_inside_nonlinear(struct sk_buff *skb, const u32 off, size = SKB_WITH_OVERHEAD(ksize(data)); - memcpy((struct skb_shared_info *)(data + size), - skb_shinfo(skb), offsetof(struct skb_shared_info, - frags[skb_shinfo(skb)->nr_frags])); if (skb_orphan_frags(skb, gfp_mask)) { kfree(data); return -ENOMEM; -- 2.19.1
| |