lkml.org 
[lkml]   [2020]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 23/45] drm/debugfs: fix plain echo to connector "force" attribute
    Date
    From: Michael Tretter <m.tretter@pengutronix.de>

    [ Upstream commit c704b17071c4dc571dca3af4e4151dac51de081a ]

    Using plain echo to set the "force" connector attribute fails with
    -EINVAL, because echo appends a newline to the output.

    Replace strcmp with sysfs_streq to also accept strings that end with a
    newline.

    v2: use sysfs_streq instead of stripping trailing whitespace

    Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
    Reviewed-by: Jani Nikula <jani.nikula@intel.com>
    Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20170817104307.17124-1-m.tretter@pengutronix.de
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/drm_debugfs.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
    index eab0f2687cd6e..00debd02c3220 100644
    --- a/drivers/gpu/drm/drm_debugfs.c
    +++ b/drivers/gpu/drm/drm_debugfs.c
    @@ -337,13 +337,13 @@ static ssize_t connector_write(struct file *file, const char __user *ubuf,

    buf[len] = '\0';

    - if (!strcmp(buf, "on"))
    + if (sysfs_streq(buf, "on"))
    connector->force = DRM_FORCE_ON;
    - else if (!strcmp(buf, "digital"))
    + else if (sysfs_streq(buf, "digital"))
    connector->force = DRM_FORCE_ON_DIGITAL;
    - else if (!strcmp(buf, "off"))
    + else if (sysfs_streq(buf, "off"))
    connector->force = DRM_FORCE_OFF;
    - else if (!strcmp(buf, "unspecified"))
    + else if (sysfs_streq(buf, "unspecified"))
    connector->force = DRM_FORCE_UNSPECIFIED;
    else
    return -EINVAL;
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-08-10 21:24    [W:4.224 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site