lkml.org 
[lkml]   [2020]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 05/11] perf intel-pt: Use itrace error flags to suppress some errors
    From
    Date
    On 9/07/20 9:13 pm, Adrian Hunter wrote:
    > On 9/07/20 8:50 pm, Andi Kleen wrote:
    >> On Thu, Jul 09, 2020 at 08:36:22PM +0300, Adrian Hunter wrote:
    >>> The itrace "e" option may be followed by a number which has the
    >>> following effect for Intel PT:
    >>> 1 Suppress overflow events
    >>> 2 Suppress trace data lost events
    >>> The values may be combined by bitwise OR'ing them.
    >>>
    >>> Suppressing those errors can be useful for testing and debugging
    >>> because they are not due to decoding.
    >>
    >> I suspect it will be useful to more than just decoding and debugging.
    >>
    >> But the number is not a nice user interface.
    >>
    >> How about e[....]
    >>
    >> like e[ol]
    >
    > Do you mean literally square-brackets? If you were really unlucky you might
    > get pathname expansion with that.
    >
    >>
    >> Also it's a bit unusual that this disables instead of enables, but ok.

    What about prefixing each flag with - i.e.

    e-o
    e-l
    e-o-l

    \
     
     \ /
      Last update: 2020-07-09 20:23    [W:2.838 / U:0.412 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site