lkml.org 
[lkml]   [2020]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usbip: Use fallthrough pseudo-keyword
On 2020-07-08 07:35, Shuah Khan wrote:
> On 7/7/20 7:56 PM, Joe Perches wrote:
>> On Tue, 2020-07-07 at 14:06 -0600, Shuah Khan wrote:
>>> On 7/7/20 1:52 PM, Gustavo A. R. Silva wrote:
>>>> Replace the existing /* fall through */ comments and its variants
>>>> with
>>>> the new pseudo-keyword macro fallthrough[1]. Also, remove
>>>> unnecessary
>>>> fall-through markings when it is the case.
>>>>
>>>> [1]
>>>> https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>>>>
>>>
>>> Is fallthrough syntax supported on our min gcc version?
>>
>> No. Introduced in gcc 7.
>>
>
> Gustavo,
>
> In which case, this patch would break usbip build on older gcc
> revisions.

No it will not. Comment fall through was introduced in gcc 7 and this
devolved into a do while 0
> thanks,
> -- Shuah

\
 
 \ /
  Last update: 2020-07-08 17:40    [W:0.105 / U:1.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site