lkml.org 
[lkml]   [2020]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [EXT] [PATCH 4/5] net: fec: get rid of redundant code in fec_ptp_set()
Date
Andy Duan <fugang.duan@nxp.com> writes:

> From: Sergey Organov <sorganov@gmail.com> Sent: Wednesday, July 8, 2020 4:49 PM
>> Andy Duan <fugang.duan@nxp.com> writes:
>>
>> > From: Sergey Organov <sorganov@gmail.com> Sent: Tuesday, July 7, 2020
>> > 10:43 PM
>> >> Andy Duan <fugang.duan@nxp.com> writes:
>> >>
>> >> > From: Sergey Organov <sorganov@gmail.com> Sent: Monday, July 6,
>> >> > 2020
>> >> 10:26 PM
>> >> >> Code of the form "if(x) x = 0" replaced with "x = 0".
>> >> >>
>> >> >> Code of the form "if(x == a) x = a" removed.
>> >> >>
>> >> >> Signed-off-by: Sergey Organov <sorganov@gmail.com>
>> >> >> ---
>> >> >> drivers/net/ethernet/freescale/fec_ptp.c | 4 +---
>> >> >> 1 file changed, 1 insertion(+), 3 deletions(-)
>> >> >>
>> >> >> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
>> >> >> b/drivers/net/ethernet/freescale/fec_ptp.c
>> >> >> index e455343..4152cae 100644
>> >> >> --- a/drivers/net/ethernet/freescale/fec_ptp.c
>> >> >> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
>> >> >> @@ -485,9 +485,7 @@ int fec_ptp_set(struct net_device *ndev,
>> >> >> struct
>> >> ifreq
>> >> >> *ifr)
>> >> >>
>> >> >> switch (config.rx_filter) {
>> >> >> case HWTSTAMP_FILTER_NONE:
>> >> >> - if (fep->hwts_rx_en)
>> >> >> - fep->hwts_rx_en = 0;
>> >> >> - config.rx_filter = HWTSTAMP_FILTER_NONE;
>
> The original patch seems fine. Thanks!
>
> For the patch: Acked-by: Fugang Duan <fugang.duan@nxp.com>

OK, thanks for reviewing!

-- Sergey

\
 
 \ /
  Last update: 2020-07-08 14:27    [W:0.092 / U:0.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site