lkml.org 
[lkml]   [2020]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/30] scsi: qedf: qedf_main: Remove set but not checked variable 'tmp'
    Date
    Looks like the return value of readw() has never been checked.

    Fixes the following W=1 kernel build warning(s):

    drivers/scsi/qedf/qedf_main.c: In function ‘__qedf_probe’:
    drivers/scsi/qedf/qedf_main.c:3203:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable]

    Cc: QLogic-Storage-Upstream@cavium.com
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/scsi/qedf/qedf_main.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
    index a77a74fad6a7e..47fc14f5ed9d7 100644
    --- a/drivers/scsi/qedf/qedf_main.c
    +++ b/drivers/scsi/qedf/qedf_main.c
    @@ -3199,7 +3199,6 @@ static int __qedf_probe(struct pci_dev *pdev, int mode)
    void *task_start, *task_end;
    struct qed_slowpath_params slowpath_params;
    struct qed_probe_params qed_params;
    - u16 tmp;

    /*
    * When doing error recovery we didn't reap the lport so don't try
    @@ -3393,9 +3392,9 @@ static int __qedf_probe(struct pci_dev *pdev, int mode)
    "Writing %d to primary and secondary BDQ doorbell registers.\n",
    qedf->bdq_prod_idx);
    writew(qedf->bdq_prod_idx, qedf->bdq_primary_prod);
    - tmp = readw(qedf->bdq_primary_prod);
    + readw(qedf->bdq_primary_prod);
    writew(qedf->bdq_prod_idx, qedf->bdq_secondary_prod);
    - tmp = readw(qedf->bdq_secondary_prod);
    + readw(qedf->bdq_secondary_prod);

    qed_ops->common->set_power_state(qedf->cdev, PCI_D0);

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-07-08 14:03    [W:4.313 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site