lkml.org 
[lkml]   [2020]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] fs: ceph: Remove unnecessary cast in kfree()
On Wed, Jul 8, 2020 at 9:27 AM Xu Wang <vulab@iscas.ac.cn> wrote:
>
> Remove unnecassary casts in the argument to kfree.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
> fs/ceph/xattr.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c
> index 71ee34d160c3..3a733ac33d9b 100644
> --- a/fs/ceph/xattr.c
> +++ b/fs/ceph/xattr.c
> @@ -497,10 +497,10 @@ static int __set_xattr(struct ceph_inode_info *ci,
> kfree(*newxattr);
> *newxattr = NULL;
> if (xattr->should_free_val)
> - kfree((void *)xattr->val);
> + kfree(xattr->val);
>
> if (update_xattr) {
> - kfree((void *)name);
> + kfree(name);
> name = xattr->name;
> }
> ci->i_xattrs.names_size -= xattr->name_len;
> @@ -566,9 +566,9 @@ static void __free_xattr(struct ceph_inode_xattr *xattr)
> BUG_ON(!xattr);
>
> if (xattr->should_free_name)
> - kfree((void *)xattr->name);
> + kfree(xattr->name);
> if (xattr->should_free_val)
> - kfree((void *)xattr->val);
> + kfree(xattr->val);
>
> kfree(xattr);
> }
> @@ -582,9 +582,9 @@ static int __remove_xattr(struct ceph_inode_info *ci,
> rb_erase(&xattr->node, &ci->i_xattrs.index);
>
> if (xattr->should_free_name)
> - kfree((void *)xattr->name);
> + kfree(xattr->name);
> if (xattr->should_free_val)
> - kfree((void *)xattr->val);
> + kfree(xattr->val);
>
> ci->i_xattrs.names_size -= xattr->name_len;
> ci->i_xattrs.vals_size -= xattr->val_len;

Applied.

Thanks,

Ilya

\
 
 \ /
  Last update: 2020-07-08 12:39    [W:0.052 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site