lkml.org 
[lkml]   [2020]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: mmotm 2020-07-08-19-28 uploaded (mm/migrate.c)
From
Date


On 07/09/2020 09:17 AM, Randy Dunlap wrote:
> On 7/8/20 7:29 PM, Andrew Morton wrote:
>> The mm-of-the-moment snapshot 2020-07-08-19-28 has been uploaded to
>>
>> http://www.ozlabs.org/~akpm/mmotm/
>>
>> mmotm-readme.txt says
>>
>> README for mm-of-the-moment:
>>
>> http://www.ozlabs.org/~akpm/mmotm/
>>
>> This is a snapshot of my -mm patch queue. Uploaded at random hopefully
>> more than once a week.
>>
>
> on i386:
>
> CONFIG_MIGRATION=y
> # CONFIG_TRANSPARENT_HUGEPAGE is not set
>
> ../mm/migrate.c: In function ‘migrate_pages’:
> ../mm/migrate.c:1528:19: error: ‘THP_MIGRATION_SUCCESS’ undeclared (first use in this function); did you mean ‘PGMIGRATE_SUCCESS’?
> count_vm_events(THP_MIGRATION_SUCCESS, nr_thp_succeeded);
> ^~~~~~~~~~~~~~~~~~~~~
> PGMIGRATE_SUCCESS
> ../mm/migrate.c:1528:19: note: each undeclared identifier is reported only once for each function it appears in
> ../mm/migrate.c:1530:19: error: ‘THP_MIGRATION_FAILURE’ undeclared (first use in this function); did you mean ‘THP_MIGRATION_SUCCESS’?
> count_vm_events(THP_MIGRATION_FAILURE, nr_thp_failed);
> ^~~~~~~~~~~~~~~~~~~~~
> THP_MIGRATION_SUCCESS
> ../mm/migrate.c:1532:19: error: ‘THP_MIGRATION_SPLIT’ undeclared (first use in this function); did you mean ‘THP_MIGRATION_FAILURE’?
> count_vm_events(THP_MIGRATION_SPLIT, nr_thp_split);
> ^~~~~~~~~~~~~~~~~~~
> THP_MIGRATION_FAILURE

These events should always be available without any config dependency
including CONFIG_TRANSPARENT_HUGEPAGE. Will fix this and update the
patch.

\
 
 \ /
  Last update: 2020-07-09 05:58    [W:0.056 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site