Messages in this thread | | | From | Arnd Bergmann <> | Date | Wed, 8 Jul 2020 22:39:57 +0200 | Subject | Re: [PATCH 4/4] firmware: arm_scmi: Remove fixed size typing from event reports |
| |
On Wed, Jul 8, 2020 at 2:25 PM Cristian Marussi <cristian.marussi@arm.com> wrote: > > Event reports are used to convey information describing events to the > registered user-callbacks: they are necessarily derived from the underlying > raw SCMI events' messages but they are not meant to expose or directly > mirror any of those messages data layout, which belong to the protocol > layer. > > Using fixed size fields mirroring messages structure is at odd with this: > get rid of them using more generic, equivalent, typing. > > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
Ok, I was expecting you would go with fixed-size structures without implied padding, but either way makes it more consistent, so this version is good, too.
Arnd
| |