Messages in this thread | | | From | Sergey Organov <> | Subject | Re: [EXT] [PATCH 4/5] net: fec: get rid of redundant code in fec_ptp_set() | Date | Tue, 07 Jul 2020 17:43:22 +0300 |
| |
Andy Duan <fugang.duan@nxp.com> writes:
> From: Sergey Organov <sorganov@gmail.com> Sent: Monday, July 6, 2020 10:26 PM >> Code of the form "if(x) x = 0" replaced with "x = 0". >> >> Code of the form "if(x == a) x = a" removed. >> >> Signed-off-by: Sergey Organov <sorganov@gmail.com> >> --- >> drivers/net/ethernet/freescale/fec_ptp.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c >> b/drivers/net/ethernet/freescale/fec_ptp.c >> index e455343..4152cae 100644 >> --- a/drivers/net/ethernet/freescale/fec_ptp.c >> +++ b/drivers/net/ethernet/freescale/fec_ptp.c >> @@ -485,9 +485,7 @@ int fec_ptp_set(struct net_device *ndev, struct ifreq >> *ifr) >> >> switch (config.rx_filter) { >> case HWTSTAMP_FILTER_NONE: >> - if (fep->hwts_rx_en) >> - fep->hwts_rx_en = 0; >> - config.rx_filter = HWTSTAMP_FILTER_NONE; > The line should keep according your commit log.
You mean I should fix commit log like this:
Code of the form "switch(x) case a: x = a; break" removed.
?
I'll do if it's cleaner that way.
Thanks, -- Sergey
> >> + fep->hwts_rx_en = 0; >> break; >> >> default: >> -- >> 2.10.0.1.g57b01a3
| |