lkml.org 
[lkml]   [2020]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 04/28] ASoC: fsl: fsl_asrc: Demote obvious misuse of kerneldoc to standard comment blocks
    Date
    No attempt has been made to document any of the demoted functions here.

    Fixes the following W=1 kernel build warning(s):

    sound/soc/fsl/fsl_asrc.c:44: warning: cannot understand function prototype: 'unsigned char input_clk_map_imx35[ASRC_CLK_MAP_LEN] = '
    sound/soc/fsl/fsl_asrc.c:78: warning: cannot understand function prototype: 'unsigned char clk_map_imx8qm[2][ASRC_CLK_MAP_LEN] = '
    sound/soc/fsl/fsl_asrc.c:118: warning: Function parameter or member 'inrate' not described in 'fsl_asrc_sel_proc'
    sound/soc/fsl/fsl_asrc.c:118: warning: Function parameter or member 'outrate' not described in 'fsl_asrc_sel_proc'
    sound/soc/fsl/fsl_asrc.c:118: warning: Function parameter or member 'pre_proc' not described in 'fsl_asrc_sel_proc'
    sound/soc/fsl/fsl_asrc.c:118: warning: Function parameter or member 'post_proc' not described in 'fsl_asrc_sel_proc'
    sound/soc/fsl/fsl_asrc.c:158: warning: Function parameter or member 'channels' not described in 'fsl_asrc_request_pair'
    sound/soc/fsl/fsl_asrc.c:158: warning: Function parameter or member 'pair' not described in 'fsl_asrc_request_pair'
    sound/soc/fsl/fsl_asrc.c:201: warning: Function parameter or member 'pair' not described in 'fsl_asrc_release_pair'
    sound/soc/fsl/fsl_asrc.c:223: warning: Function parameter or member 'pair' not described in 'fsl_asrc_set_watermarks'
    sound/soc/fsl/fsl_asrc.c:223: warning: Function parameter or member 'in' not described in 'fsl_asrc_set_watermarks'
    sound/soc/fsl/fsl_asrc.c:223: warning: Function parameter or member 'out' not described in 'fsl_asrc_set_watermarks'
    sound/soc/fsl/fsl_asrc.c:242: warning: Function parameter or member 'pair' not described in 'fsl_asrc_cal_asrck_divisor'
    sound/soc/fsl/fsl_asrc.c:242: warning: Function parameter or member 'div' not described in 'fsl_asrc_cal_asrck_divisor'
    sound/soc/fsl/fsl_asrc.c:259: warning: Function parameter or member 'pair' not described in 'fsl_asrc_set_ideal_ratio'
    sound/soc/fsl/fsl_asrc.c:259: warning: Function parameter or member 'inrate' not described in 'fsl_asrc_set_ideal_ratio'
    sound/soc/fsl/fsl_asrc.c:259: warning: Function parameter or member 'outrate' not described in 'fsl_asrc_set_ideal_ratio'
    sound/soc/fsl/fsl_asrc.c:310: warning: Function parameter or member 'pair' not described in 'fsl_asrc_config_pair'
    sound/soc/fsl/fsl_asrc.c:310: warning: Function parameter or member 'use_ideal_rate' not described in 'fsl_asrc_config_pair'
    sound/soc/fsl/fsl_asrc.c:516: warning: Function parameter or member 'pair' not described in 'fsl_asrc_start_pair'
    sound/soc/fsl/fsl_asrc.c:545: warning: Function parameter or member 'pair' not described in 'fsl_asrc_stop_pair'
    sound/soc/fsl/fsl_asrc.c:559: warning: Function parameter or member 'pair' not described in 'fsl_asrc_get_dma_channel'
    sound/soc/fsl/fsl_asrc.c:559: warning: Function parameter or member 'dir' not described in 'fsl_asrc_get_dma_channel'
    sound/soc/fsl/fsl_asrc.c:902: warning: Function parameter or member 'asrc' not described in 'fsl_asrc_init'
    sound/soc/fsl/fsl_asrc.c:936: warning: Function parameter or member 'irq' not described in 'fsl_asrc_isr'
    sound/soc/fsl/fsl_asrc.c:936: warning: Function parameter or member 'dev_id' not described in 'fsl_asrc_isr'

    Cc: Timur Tabi <timur@kernel.org>
    Cc: Nicolin Chen <nicoleotsuka@gmail.com>
    Cc: Xiubo Li <Xiubo.Lee@gmail.com>
    Cc: Fabio Estevam <festevam@gmail.com>
    Cc: linuxppc-dev@lists.ozlabs.org
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    sound/soc/fsl/fsl_asrc.c | 28 ++++++++++++++--------------
    1 file changed, 14 insertions(+), 14 deletions(-)

    diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c
    index 462ce9f9ab488..209bf80dc3670 100644
    --- a/sound/soc/fsl/fsl_asrc.c
    +++ b/sound/soc/fsl/fsl_asrc.c
    @@ -37,7 +37,7 @@ static struct snd_pcm_hw_constraint_list fsl_asrc_rate_constraints = {
    .list = supported_asrc_rate,
    };

    -/**
    +/*
    * The following tables map the relationship between asrc_inclk/asrc_outclk in
    * fsl_asrc.h and the registers of ASRCSR
    */
    @@ -68,7 +68,7 @@ static unsigned char output_clk_map_imx53[ASRC_CLK_MAP_LEN] = {
    0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7,
    };

    -/**
    +/*
    * i.MX8QM/i.MX8QXP uses the same map for input and output.
    * clk_map_imx8qm[0] is for i.MX8QM asrc0
    * clk_map_imx8qm[1] is for i.MX8QM asrc1
    @@ -101,7 +101,7 @@ static unsigned char clk_map_imx8qxp[2][ASRC_CLK_MAP_LEN] = {
    },
    };

    -/**
    +/*
    * Select the pre-processing and post-processing options
    * Make sure to exclude following unsupported cases before
    * calling this function:
    @@ -147,7 +147,7 @@ static void fsl_asrc_sel_proc(int inrate, int outrate,
    *post_proc = 1;
    }

    -/**
    +/*
    * Request ASRC pair
    *
    * It assigns pair by the order of A->C->B because allocation of pair B,
    @@ -192,7 +192,7 @@ static int fsl_asrc_request_pair(int channels, struct fsl_asrc_pair *pair)
    return ret;
    }

    -/**
    +/*
    * Release ASRC pair
    *
    * It clears the resource from asrc and releases the occupied channels.
    @@ -216,7 +216,7 @@ static void fsl_asrc_release_pair(struct fsl_asrc_pair *pair)
    spin_unlock_irqrestore(&asrc->lock, lock_flags);
    }

    -/**
    +/*
    * Configure input and output thresholds
    */
    static void fsl_asrc_set_watermarks(struct fsl_asrc_pair *pair, u32 in, u32 out)
    @@ -233,7 +233,7 @@ static void fsl_asrc_set_watermarks(struct fsl_asrc_pair *pair, u32 in, u32 out)
    ASRMCRi_OUTFIFO_THRESHOLD(out));
    }

    -/**
    +/*
    * Calculate the total divisor between asrck clock rate and sample rate
    *
    * It follows the formula clk_rate = samplerate * (2 ^ prescaler) * divider
    @@ -249,7 +249,7 @@ static u32 fsl_asrc_cal_asrck_divisor(struct fsl_asrc_pair *pair, u32 div)
    return ((div - 1) << ASRCDRi_AxCPi_WIDTH) | ps;
    }

    -/**
    +/*
    * Calculate and set the ratio for Ideal Ratio mode only
    *
    * The ratio is a 32-bit fixed point value with 26 fractional bits.
    @@ -292,7 +292,7 @@ static int fsl_asrc_set_ideal_ratio(struct fsl_asrc_pair *pair,
    return 0;
    }

    -/**
    +/*
    * Configure the assigned ASRC pair
    *
    * It configures those ASRC registers according to a configuration instance
    @@ -507,7 +507,7 @@ static int fsl_asrc_config_pair(struct fsl_asrc_pair *pair, bool use_ideal_rate)
    return fsl_asrc_set_ideal_ratio(pair, inrate, outrate);
    }

    -/**
    +/*
    * Start the assigned ASRC pair
    *
    * It enables the assigned pair and makes it stopped at the stall level.
    @@ -538,7 +538,7 @@ static void fsl_asrc_start_pair(struct fsl_asrc_pair *pair)
    regmap_write(asrc->regmap, REG_ASRIER, ASRIER_AOLIE);
    }

    -/**
    +/*
    * Stop the assigned ASRC pair
    */
    static void fsl_asrc_stop_pair(struct fsl_asrc_pair *pair)
    @@ -551,7 +551,7 @@ static void fsl_asrc_stop_pair(struct fsl_asrc_pair *pair)
    ASRCTR_ASRCEi_MASK(index), 0);
    }

    -/**
    +/*
    * Get DMA channel according to the pair and direction.
    */
    static struct dma_chan *fsl_asrc_get_dma_channel(struct fsl_asrc_pair *pair,
    @@ -895,7 +895,7 @@ static const struct regmap_config fsl_asrc_regmap_config = {
    .cache_type = REGCACHE_FLAT,
    };

    -/**
    +/*
    * Initialize ASRC registers with a default configurations
    */
    static int fsl_asrc_init(struct fsl_asrc *asrc)
    @@ -929,7 +929,7 @@ static int fsl_asrc_init(struct fsl_asrc *asrc)
    return regmap_write(asrc->regmap, REG_ASR56K, ipg_rate / 56000);
    }

    -/**
    +/*
    * Interrupt handler for ASRC
    */
    static irqreturn_t fsl_asrc_isr(int irq, void *dev_id)
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-07-07 16:38    [W:4.022 / U:0.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site