Messages in this thread | | | From | Daniel Rosenberg <> | Date | Tue, 7 Jul 2020 03:44:06 -0700 | Subject | Re: [PATCH v9 4/4] ext4: Use generic casefolding support |
| |
On Tue, Jun 23, 2020 at 10:43 PM Gabriel Krisman Bertazi <krisman@collabora.com> wrote: > > Daniel Rosenberg <drosen@google.com> writes: > > > - > > const struct dentry_operations ext4_dentry_ops = { > > - .d_hash = ext4_d_hash, > > - .d_compare = ext4_d_compare, > > + .d_hash = generic_ci_d_hash, > > + .d_compare = generic_ci_d_compare, > > }; > > #endif > > Can you make the structure generic since it is the same for f2fs and > ext4, which let you drop the code guards? Unless that becomes a problem for > d_revalidate with fscrypt, it is fine like this. > > -- > Gabriel Krisman Bertazi
I unify them in a later patch, since I end up having to deal with fscrypt's d_revalidate. With that patch I'd end up undoing the export I'd add for this, so I'll skip that for the moment.
-Daniel
| |