Messages in this thread | | | Subject | Re: [PATCH 2/2] selftest/cpuidle: Add support for cpuidle latency measurement | From | Pratik Sampat <> | Date | Tue, 7 Jul 2020 21:23:46 +0530 |
| |
[..snip..] >> + >> +ins_mod() >> +{ >> + if [ ! -f "$MODULE" ]; then >> + printf "$MODULE module does not exist. Exitting\n" >> + exit 2 > > Please use ksft_skip code to indicate the test is being skipped. > Sure thing I'll use ksft_skip exit code instead. >> + fi >> + printf "Inserting $MODULE module\n\n" >> + insmod $MODULE >> + if [ $? != 0 ]; then >> + printf "Insmod $MODULE failed\n" >> + exit 2 > > This is fine since you expect to be able to load the module. > Thanks for the review. Pratik
[..snip..] >> > > thanks, > -- Shuah
| |