Messages in this thread | | | Date | Mon, 6 Jul 2020 22:06:48 +0000 | From | Wei Yang <> | Subject | Re: [RESEND Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little |
| |
On Mon, Jul 06, 2020 at 01:08:19PM +0300, Kirill A. Shutemov wrote: >On Fri, Jun 26, 2020 at 09:52:12PM +0800, Wei Yang wrote: >> move_page_tables() tries to move page table by PMD or PTE. >> >> The root reason is if it tries to move PMD, both old and new range should be >> PMD aligned. But current code calculate old range and new range separately. >> This leads to some redundant check and calculation. >> >> This cleanup tries to consolidate the range check in one place to reduce some >> extra range handling. > >The patchet looks good to me. I have few nits, but nothing substantial. > >Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> >
Hi, Kirill
Thanks for your review.
Andrew,
Do you want me to send another version or you would like to adjust it directly?
>-- > Kirill A. Shutemov
-- Wei Yang Help you, Help me
| |