Messages in this thread | | | Subject | Re: [PATCH] drm/i915: Fix spelling mistake in i915_reg.h | From | Chris Wilson <> | Date | Mon, 06 Jul 2020 18:19:49 +0100 |
| |
Quoting Flavio Suligoi (2020-07-03 13:50:46) > Fix typo: "TRIGER" --> "TRIGGER" > > The two misplelled macros: > > 1) OAREPORTTRIG1_EDGE_LEVEL_TRIGER_SELECT_MASK > 2) OAREPORTTRIG5_EDGE_LEVEL_TRIGER_SELECT_MASK > > are not used in any other sources of the kernel, > so this change can be consider only a local change > for the i915_reg.h file. > > Signed-off-by: Flavio Suligoi <f.suligoi@asem.it> > --- > drivers/gpu/drm/i915/i915_reg.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index 9d6536afc94b..c2153364724a 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -868,7 +868,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg) > > #define OAREPORTTRIG1 _MMIO(0x2740) > #define OAREPORTTRIG1_THRESHOLD_MASK 0xffff > -#define OAREPORTTRIG1_EDGE_LEVEL_TRIGER_SELECT_MASK 0xffff0000 /* 0=level */ > +#define OAREPORTTRIG1_EDGE_LEVEL_TRIGGER_SELECT_MASK 0xffff0000 /* 0=level */ > > #define OAREPORTTRIG2 _MMIO(0x2744) > #define OAREPORTTRIG2_INVERT_A_0 (1 << 0) > @@ -921,7 +921,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg) > > #define OAREPORTTRIG5 _MMIO(0x2750) > #define OAREPORTTRIG5_THRESHOLD_MASK 0xffff > -#define OAREPORTTRIG5_EDGE_LEVEL_TRIGER_SELECT_MASK 0xffff0000 /* 0=level */ > +#define OAREPORTTRIG5_EDGE_LEVEL_TRIGGER_SELECT_MASK 0xffff0000 /* 0=level */
Ok, these names are not copied straight from the docs, so renaming them will not hinder us when finding the relevant fields.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
| |