lkml.org 
[lkml]   [2020]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH] vfio: type1: fix kthread use case
From
Date
>> Can it be helpful to convert initialisations for these variables
>> into later assignments?
>
> Perhaps. Then it looks like the below.



> +++ b/drivers/vfio/vfio_iommu_type1.c
> @@ -2798,9 +2798,12 @@ static int vfio_iommu_type1_dma_rw_chunk

> - bool kthread = current->mm == NULL;
> + bool kthread;
> + bool use_mm;

I would prefer the following variable declarations then.

+ bool kthread, use_mm;


> size_t offset;
>
> + kthread = current->flags & PF_KTHREAD;
> + use_mm = current->mm == NULL;

I propose to move such assignments directly before the corresponding check.



> if (!mm)
> return -EPERM;


+ kthread = current->flags & PF_KTHREAD;
+ use_mm = !current->mm;

> - if (kthread)
> + if (kthread && use_mm)
> kthread_use_mm(mm);


Regards,
Markus

\
 
 \ /
  Last update: 2020-07-06 15:35    [W:0.030 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site