lkml.org 
[lkml]   [2020]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] i2c: jz4780: remove redundant assignment to variable i
Hi,

Le sam. 4 juil. 2020 à 8:32, Wolfram Sang <wsa@kernel.org> a écrit :
> On Wed, Jun 10, 2020 at 01:59:01PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The variable i is being initialized with a value that is
>> never read and it is being updated later with a new value. The
>> initialization is redundant and can be removed.
>>
>> Addresses-Coverity: ("Unused value")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> What about 'ret'? Doesn't the same reasoning apply for it?
>

That's correct.

Colin, could you respin the patch and do the same for the 'ret'
variable?

Thanks,
-Paul


\
 
 \ /
  Last update: 2020-07-07 01:55    [W:0.063 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site