lkml.org 
[lkml]   [2020]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] media: rcar-vin: Update crop and compose settings for every s_fmt call
    Date
    The crop and compose settings for VIN in non mc mode werent updated
    in s_fmt call this resulted in captured images being clipped.

    With the below sequence on the third capture where size is set to
    640x480 resulted in clipped image of size 320x240.

    high(640x480) -> low (320x240) -> high (640x480)

    This patch makes sure the VIN crop and compose settings are updated.

    Fixes: 104464f573d ("media: rcar-vin: Do not reset the crop and compose rectangles in s_fmt")
    Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
    Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
    ---
    drivers/media/platform/rcar-vin/rcar-v4l2.c | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rcar-vin/rcar-v4l2.c
    index f421e25..a9b13d9 100644
    --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c
    +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c
    @@ -319,6 +319,12 @@ static int rvin_s_fmt_vid_cap(struct file *file, void *priv,
    fmt_rect.width = vin->format.width;
    fmt_rect.height = vin->format.height;

    + vin->crop.top = 0;
    + vin->crop.left = 0;
    + vin->crop.width = vin->format.width;
    + vin->crop.height = vin->format.height;
    + vin->compose = vin->crop;
    +
    v4l2_rect_map_inside(&vin->crop, &src_rect);
    v4l2_rect_map_inside(&vin->compose, &fmt_rect);
    vin->src_rect = src_rect;
    --
    2.7.4
    \
     
     \ /
      Last update: 2020-07-31 11:30    [W:2.852 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site