lkml.org 
[lkml]   [2020]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[tip: core/rcu] refperf: Dynamically allocate thread-summary output buffer
The following commit has been merged into the core/rcu branch of tip:

Commit-ID: 2e90de76f226f11fe26c871aa321be28152f565a
Gitweb: https://git.kernel.org/tip/2e90de76f226f11fe26c871aa321be28152f565a
Author: Paul E. McKenney <paulmck@kernel.org>
AuthorDate: Mon, 25 May 2020 17:45:03 -07:00
Committer: Paul E. McKenney <paulmck@kernel.org>
CommitterDate: Mon, 29 Jun 2020 12:00:44 -07:00

refperf: Dynamically allocate thread-summary output buffer

Currently, the buffer used to accumulate the thread-summary output is
fixed size, which will cause problems if someone decides to run on a large
number of PCUs. This commit therefore dynamically allocates this buffer.

[ paulmck: Fix memory allocation as suggested by KASAN. ]
Cc: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
kernel/rcu/refperf.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/kernel/rcu/refperf.c b/kernel/rcu/refperf.c
index 75b9cce..fc940e3 100644
--- a/kernel/rcu/refperf.c
+++ b/kernel/rcu/refperf.c
@@ -301,9 +301,12 @@ u64 process_durations(int n)
int i;
struct reader_task *rt;
char buf1[64];
- char buf[512];
+ char *buf;
u64 sum = 0;

+ buf = kmalloc(128 + nreaders * 32, GFP_KERNEL);
+ if (!buf)
+ return 0;
buf[0] = 0;
sprintf(buf, "Experiment #%d (Format: <THREAD-NUM>:<Total loop time in ns>)",
exp_idx);
@@ -322,6 +325,7 @@ u64 process_durations(int n)

PERFOUT("%s\n", buf);

+ kfree(buf);
return sum;
}

\
 
 \ /
  Last update: 2020-07-31 11:25    [W:0.024 / U:1.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site