Messages in this thread | | | Date | Fri, 31 Jul 2020 10:06:15 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v2 9/9] mfd: mt6360: Merge different sub-devices i2c read/write |
| |
[...]
> > > > > > +static const struct regmap_bus mt6360_regmap_bus = { > > > > > > + .read = mt6360_regmap_read, > > > > > > + .write = mt6360_regmap_write, > > > > > > + > > > > > > + /* due to pmic and ldo crc access size limit */ > > > > > > + .max_raw_read = 4, > > > > > > + .max_raw_write = 4, > > > > > > +}; > > > > > > > > > > Why isn't all of the above in a Regmap driver? > > > > > > > > > > > > > Do you means split out like drivers/base/regmap/regmap-ac97.c? > > > > > > Yes, I do. > > > > > > [...] > > > > > > > ACK > > > > After I implement first version of regmap-mt6360.c, I found out ac97 > is a intel standard codec. > If device follow this spec, it can reuse this api. > But regmap-mt6360.c may single use only. > should I try sending patch once to regmap reviewer?
Single use is okay. Putting Regmap code into MFD is not okay.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |