lkml.org 
[lkml]   [2020]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE
On Fri, Jul 31, 2020 at 10:51:30AM +0200, Jessica Yu wrote:
>> + if (mod->using_gplonly_symbols) {
>> + pr_info("%s: module using GPL-only symbols uses symbols from proprietary module %s.\n",
>> + mod->name, owner->name);
>
> pr_err() maybe?
>
>> + return false;
>> + }
>> +
>> + if (!test_bit(TAINT_PROPRIETARY_MODULE, &mod->taints)) {
>> + pr_info("%s: module uses symbols from proprietary module %s, inheriting taint.\n",
>> + mod->name, owner->name);
>
> and pr_warn()? But otherwise this looks much better.

Ok with me. Can you just fix it up, or do you want a full resend?

\
 
 \ /
  Last update: 2020-07-31 11:00    [W:0.048 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site