lkml.org 
[lkml]   [2020]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1] qed: Use %pM format specifier for MAC addresses
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Thu, 30 Jul 2020 18:59:20 +0300

> Convert to %pM instead of using custom code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/net/ethernet/qlogic/qed/qed_mcp.c | 5 ++---
> drivers/net/ethernet/qlogic/qed/qed_sriov.c | 6 ++----
> 2 files changed, 4 insertions(+), 7 deletions(-)

Thanks!

Acked-by: Alexander Lobakin <alobakin@pm.me>

> diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c b/drivers/net/ethernet/qlogic/qed/qed_mcp.c
> index 988d84564849..5be08f83e0aa 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_mcp.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_mcp.c
> @@ -2518,11 +2518,10 @@ int qed_mcp_fill_shmem_func_info(struct qed_hwfn *p_hwfn,
> }
>
> DP_VERBOSE(p_hwfn, (QED_MSG_SP | NETIF_MSG_IFUP),
> - "Read configuration from shmem: pause_on_host %02x protocol %02x BW [%02x - %02x] MAC %02x:%02x:%02x:%02x:%02x:%02x wwn port %llx node %llx ovlan %04x wol %02x\n",
> + "Read configuration from shmem: pause_on_host %02x protocol %02x BW [%02x - %02x] MAC %pM wwn port %llx node %llx ovlan %04x wol %02x\n",
> info->pause_on_host, info->protocol,
> info->bandwidth_min, info->bandwidth_max,
> - info->mac[0], info->mac[1], info->mac[2],
> - info->mac[3], info->mac[4], info->mac[5],
> + info->mac,
> info->wwn_port, info->wwn_node,
> info->ovlan, (u8)p_hwfn->hw_info.b_wol_support);
>
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_sriov.c b/drivers/net/ethernet/qlogic/qed/qed_sriov.c
> index aa215eeeb4df..9489089706fe 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_sriov.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_sriov.c
> @@ -3276,14 +3276,12 @@ static void qed_iov_vf_mbx_ucast_filter(struct qed_hwfn *p_hwfn,
>
> DP_VERBOSE(p_hwfn,
> QED_MSG_IOV,
> - "VF[%d]: opcode 0x%02x type 0x%02x [%s %s] [vport 0x%02x] MAC %02x:%02x:%02x:%02x:%02x:%02x, vlan 0x%04x\n",
> + "VF[%d]: opcode 0x%02x type 0x%02x [%s %s] [vport 0x%02x] MAC %pM, vlan 0x%04x\n",
> vf->abs_vf_id, params.opcode, params.type,
> params.is_rx_filter ? "RX" : "",
> params.is_tx_filter ? "TX" : "",
> params.vport_to_add_to,
> - params.mac[0], params.mac[1],
> - params.mac[2], params.mac[3],
> - params.mac[4], params.mac[5], params.vlan);
> + params.mac, params.vlan);
>
> if (!vf->vport_instance) {
> DP_VERBOSE(p_hwfn,
> --
> 2.27.0

Al

\
 
 \ /
  Last update: 2020-07-30 18:26    [W:0.066 / U:1.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site