[lkml]   [2020]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH v3 00/10] gpio: dwapb: Refactor GPIO resources initialization
This series is about the DW APB GPIO device initialization procedure
cleaning up. First of all it has been discovered that having a
vendor-specific "snps,nr-gpios" property isn't only redundant but also
might be dangerous (see the commit log for details). Instead we suggest to
use the generic "ngpios" property to define a number of GPIOs each DW APB
GPIO controller port supports. Secondly seeing a tendency of the other
GPIO drivers getting converted to using the GPIO-lib-based IRQ-chip
interface this series provides a patch, which replaces the DW APB GPIO
driver Generic IRQ-chip implementation with the GPIO-lib IRQ-chip one.
Finally the DW APB GPIO device probe procedure is simplified by
converting the code to be using the device managed resources for the
reference clocks initialization, reset control assertion/de-assertion
and GPIO-chip registration.

Some additional cleanups like replacing a number of GPIOs literal with a
corresponding macro and grouping the IRQ handlers up in a single place of
the driver are also introduced in this patchset.

Changelog v2:
- Replace gc->to_irq() with irq_find_mapping() method.
- Refactor dwapb_irq_set_type() method to directly set IRQ flow handler
instead of using a temporary variable.
- Initialize GPIOlib IRQ-chip settings before calling request_irq()
- Add a notice regarding regression of commit 6a2f4b7dadd5 ("gpio:
dwapb: use a second irq chip").
- Move the acpi_gpiochip_{request,free}_interrupts() methods invocation
removal to a dedicated patch.
- Move GPIO-chip to_irq callback removal to a dedicated patch.
- Add a patch which replaces a max number of GPIO literals with a macro.
- Introduce dwapb_convert_irqs() method to convert the sparse parental
IRQs array into an array of linearly distributed IRQs correctly
perceived by GPIO-lib.

Changelog v3:
- Fix patches SoB's.
- Add Andy' Suggested-by to the patch: "gpio: dwapb: Add max GPIOs macro"
- Add blank lines to the IRQ-chip conversion commit message to make it
more readable.
- Dynamically allocate memory for the IRQ-chip-related data.

Signed-off-by: Serge Semin <>
Cc: Andy Shevchenko <>
Cc: Andy Shevchenko <>
Cc: Alexey Malahov <>
Cc: Pavel Parkhomenko <>
Cc: Rob Herring <>

Serge Semin (10):
dt-bindings: gpio: dwapb: Add ngpios property support
gpio: dwapb: Add ngpios DT-property support
gpio: dwapb: Move MFD-specific IRQ handler
gpio: dwapb: Add max GPIOs macro
gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip
gpio: dwapb: Discard GPIO-to-IRQ mapping function
gpio: dwapb: Discard ACPI GPIO-chip IRQs request
gpio: dwapb: Get reset control by means of resource managed interface
gpio: dwapb: Get clocks by means of resource managed interface
gpio: dwapb: Use resource managed GPIO-chip add data method

.../bindings/gpio/snps,dw-apb-gpio.yaml | 6 +
drivers/gpio/Kconfig | 2 +-
drivers/gpio/gpio-dwapb.c | 352 +++++++++---------
include/linux/platform_data/gpio-dwapb.h | 4 +-
4 files changed, 191 insertions(+), 173 deletions(-)


 \ /
  Last update: 2020-07-30 17:28    [W:0.060 / U:13.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site