lkml.org 
[lkml]   [2020]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 06/10] gpio: dwapb: Discard GPIO-to-IRQ mapping function
On Thu, Jul 30, 2020 at 04:55:32PM +0300, Serge Semin wrote:
> Since GPIOlib-based IRQ-chip interface is now utilized there is no need in
> setting up a custom GPIO-to-IRQ mapping method. GPIO-lib defines the
> standard mapping method - gpiochip_to_irq(), which will be used anyway no
> matter whether the custom to_irq callback is specified or not.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
>
> ---
>
> Changelog v2:
> - This is a new patch detached from commit
> "gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip".
> ---
> drivers/gpio/gpio-dwapb.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index 327333fbc750..f7acc5abbf5c 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -150,14 +150,6 @@ static inline void dwapb_write(struct dwapb_gpio *gpio, unsigned int offset,
> gc->write_reg(reg_base + gpio_reg_convert(gpio, offset), val);
> }
>
> -static int dwapb_gpio_to_irq(struct gpio_chip *gc, unsigned offset)
> -{
> - struct dwapb_gpio_port *port = gpiochip_get_data(gc);
> - struct dwapb_gpio *gpio = port->gpio;
> -
> - return irq_find_mapping(gpio->domain, offset);
> -}
> -
> static struct dwapb_gpio_port *dwapb_offs_to_port(struct dwapb_gpio *gpio, unsigned int offs)
> {
> struct dwapb_gpio_port *port;
> @@ -466,8 +458,6 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
> }
>
> girq->chip = &port->irqchip;
> -
> - port->gc.to_irq = dwapb_gpio_to_irq;
> }
>
> static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
> --
> 2.27.0
>

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2020-07-30 16:27    [W:0.122 / U:14.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site