[lkml]   [2020]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] f2fs: make file immutable even if releasing zero compression block
From: Daeho Jeong <>

When we use F2FS_IOC_RELEASE_COMPRESS_BLOCKS ioctl, if we can't find
any compressed blocks in the file even with large file size, the
ioctl just ends up without changing the file's status as immutable.
It makes the user, who expects that the file is immutable when it
returns successfully, confused.

Signed-off-by: Daeho Jeong <>
fs/f2fs/file.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index cc7f5670390f..8a422400e824 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -3535,14 +3535,14 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg)
if (ret)
goto out;

- if (!F2FS_I(inode)->i_compr_blocks)
- goto out;
F2FS_I(inode)->i_flags |= F2FS_IMMUTABLE_FL;
inode->i_ctime = current_time(inode);
f2fs_mark_inode_dirty_sync(inode, true);

+ if (!F2FS_I(inode)->i_compr_blocks)
+ goto out;

 \ /
  Last update: 2020-07-30 07:11    [W:0.038 / U:8.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site