Messages in this thread | | | Date | Thu, 30 Jul 2020 17:36:10 -0700 (PDT) | Subject | Re: [PATCH] atm: fix atm_dev refcnt leaks in atmtcp_remove_persistent | From | David Miller <> |
| |
From: Xin Xiong <xiongx18@fudan.edu.cn> Date: Wed, 29 Jul 2020 21:06:59 +0800
> atmtcp_remove_persistent() invokes atm_dev_lookup(), which returns a > reference of atm_dev with increased refcount or NULL if fails. > > The refcount leaks issues occur in two error handling paths. If > dev_data->persist is zero or PRIV(dev)->vcc isn't NULL, the function > returns 0 without decreasing the refcount kept by a local variable, > resulting in refcount leaks. > > Fix the issue by adding atm_dev_put() before returning 0 both when > dev_data->persist is zero or PRIV(dev)->vcc isn't NULL. > > Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn> > Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn> > Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Applied, thank you.
| |