lkml.org 
[lkml]   [2020]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] PM / devfreq: Add governor flags to clarify the features
From
Date
03.07.2020 13:08, Chanwoo Choi пишет:
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index e94a27804c20..620ecd250d7c 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -765,10 +765,12 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
>
> static struct devfreq_governor tegra_devfreq_governor = {
> .name = "tegra_actmon",
> + .flag = DEVFREQ_GOV_FLAG_ATTR_COMMON
> + | DEVFREQ_GOV_FLAG_ATTR_POLLING_INTERVAL,

Hello, Chanwoo!

There is a typo here, it should be ".attr = ".

> + .flag = DEVFREQ_GOV_FLAG_FLAG_IMMUTABLE,
> + | DEVFREQ_GOV_FLAG_FLAG_IRQ_DRIVEN,

There is a typo here too FLAG_FLAG ^

> .get_target_freq = tegra_governor_get_target,
> .event_handler = tegra_governor_event_handler,
> - .immutable = true,
> - .interrupt_driven = true,
> };
>

\
 
 \ /
  Last update: 2020-07-03 12:47    [W:1.097 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site